Modify rule S4663: Add support for C# and VB.NET (#1513)

* Modify metadata for csharp * Modify metadata for vbnet * Fix some references * Apply PR Review fixes * Apply PR Review changes
SonarSource · Jan 25, 2023 · 349708e · 349708e
1 parent 2097c8e
commit 349708e
Show file tree

Hide file tree

Showing 8 changed files with 34 additions and 4 deletions.
diff --git a/rules/S4663/csharp/description.adoc b/rules/S4663/csharp/description.adoc
@@ -0,0 +1 @@
+An empty comment is likely to be a mistake and doesn't help to improve the readability of the code. For these reasons, it should be removed.
diff --git a/rules/S4663/csharp/metadata.json b/rules/S4663/csharp/metadata.json
@@ -1,3 +1,3 @@
 {
-
+    "title": "Comments should not be empty"
 }
diff --git a/rules/S4663/csharp/noncompliant.adoc b/rules/S4663/csharp/noncompliant.adoc
@@ -0,0 +1,14 @@
+== Noncompliant Code Example
+
+[source,text]
+----
+//
+
+/*
+*/
+
+///
+
+/**
+*/
+----
diff --git a/rules/S4663/csharp/rule.adoc b/rules/S4663/csharp/rule.adoc
@@ -1,4 +1,7 @@
-include::../rule.adoc[]
+include::description.adoc[]
+
+include::noncompliant.adoc[]
+
 ifdef::env-github,rspecator-view[]
 
 '''

diff --git a/rules/S4663/vbnet/description.adoc b/rules/S4663/vbnet/description.adoc
@@ -0,0 +1 @@
+An empty comment is likely to be a mistake and doesn't help to improve the readability of the code. For these reasons, it should be removed.
diff --git a/rules/S4663/vbnet/metadata.json b/rules/S4663/vbnet/metadata.json
@@ -1,3 +1,3 @@
 {
-
+    "title": "Comments should not be empty"
 }
diff --git a/rules/S4663/vbnet/noncompliant.adoc b/rules/S4663/vbnet/noncompliant.adoc
@@ -0,0 +1,8 @@
+== Noncompliant Code Example
+
+[source,text]
+----
+'
+
+'''
+----
diff --git a/rules/S4663/vbnet/rule.adoc b/rules/S4663/vbnet/rule.adoc
@@ -1,4 +1,7 @@
-include::../rule.adoc[]
+include::description.adoc[]
+
+include::noncompliant.adoc[]
+
 ifdef::env-github,rspecator-view[]
 
 '''