Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port colorconverter YCbCr and YCCk to arm #2417

Merged
merged 10 commits into from
Mar 29, 2023
Merged

Port colorconverter YCbCr and YCCk to arm #2417

merged 10 commits into from
Mar 29, 2023

Conversation

stefannikolei
Copy link
Contributor

@stefannikolei stefannikolei commented Mar 26, 2023 •
edited

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Benchmark:
YCbCr

Method Mean Error StdDev
Scalar 4,777.9 ns 15.98 ns 14.95 ns
SimdVector8 295.5 ns 1.07 ns 1.00 ns
SimdVectorAvx NA NA NA
SimdVectorArm 188.3 ns 0.87 ns 0.77 ns

YCCk

Method Mean Error StdDev Ratio RatioSD
Scalar 5,934.5 ns 12.66 ns 11.22 ns 1.00 0.00
SimdVector8 327.8 ns 0.74 ns 0.70 ns 0.06 0.00
SimdVectorAvx2 NA NA NA ? ?
SimdVectorArm64 228.3 ns 0.47 ns 0.42 ns 0.04 0.00

@stefannikolei stefannikolei force-pushed the stefannikolei/arm/colorconverter_ycbcrarm branch from f0a1ceb to 9dddb8c Compare March 26, 2023 12:37
@stefannikolei stefannikolei changed the title Port colorconverter YCbCr to arm Port colorconverter YCbCr and YCCk to arm Mar 27, 2023
@stefannikolei
Copy link
Contributor Author

With this all Jpeg ColorConverters have ARM specific code

@stefannikolei stefannikolei mentioned this pull request Mar 27, 2023
Merged
4 tasks
@antonfirsov
Copy link
Member

This PR has to adapt the test changes from #2416 now.

@stefannikolei stefannikolei force-pushed the stefannikolei/arm/colorconverter_ycbcrarm branch from 904520d to 7b13ae2 Compare March 28, 2023 04:51
antonfirsov
antonfirsov reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if the output images look good.

tests/ImageSharp.Tests/Formats/Jpg/JpegColorConverterTests.cs Show resolved Hide resolved
tests/ImageSharp.Tests/Formats/Jpg/JpegColorConverterTests.cs Outdated Show resolved Hide resolved
antonfirsov
antonfirsov approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JimBobSquarePants JimBobSquarePants merged commit 4989e14 into SixLabors:main Mar 29, 2023
7 checks passed
@stefannikolei stefannikolei deleted the stefannikolei/arm/colorconverter_ycbcrarm branch April 2, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees
No one assigned
Labels
arch:arm32 arch:arm64 formats:jpeg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stefannikolei @antonfirsov @JimBobSquarePants @brianpopow