Add support for decoding tiff images with CieLab color space #2127
+188
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoidl
reviewed
May 27, 2022
src/ImageSharp/Formats/Tiff/PhotometricInterpretation/CieLabPlanarTiffColor{TPixel}.cs
Outdated
Show resolved
Hide resolved
src/ImageSharp/Formats/Tiff/PhotometricInterpretation/CieLabTiffColor{TPixel}.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Günther Foidl <gue@korporal.at>
| where TPixel : unmanaged, IPixel<TPixel> | ||
| { | ||
| // Note: The image from MagickReferenceDecoder does not look right, maybe we are doing something wrong | ||
| // converting the pixel data from Magick.NET to our format with CieLab? |
There was a problem hiding this comment.
What's happening here?
There was a problem hiding this comment.
The image Tiff\CieLab.tiff looks wrong when using the MagickReferenceDecoder:
It should look like this:
ImageMagick itself can decode this image just fine, that's why I thought we maybe doing something wrong in MagickReferenceDecoder.
There was a problem hiding this comment.
Ah right.... Yep,
IMagickImage<T> contains ColorSpace enum which we are blindly ignoring when converting. I always assumed they did the same as us and converted color spaces on decode.
It looks like we should be checking that first and converting on the fly.
@dlemstra Am I correct here?
JimBobSquarePants
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds support for decoding Tiff images with the CieLab color space.