Dismiss pruning alerts for contract IDs that are no longer prunable #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests this PR dismisses stale prune alerts. This is important because we currently don't dismiss alerts if the contracts is not listed as prunable, this can be because it dropped out of the contract set but also on renewals for instance. It's kind of annoying to do this though because alert IDs are hashes but the state I had to keep is very very minimal imo. Took the opportunity to get rid of
pruneResultwhich has always bothered me a bit. I also changed it so we only send a metric when either the error wasnilor we managed to pruned at least 1 byte. That makes sense I think, we currently log metrics for failures too but not sure why we did that in the first place.