Migrate RenameObject to raw SQL #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/rename-object-migration
branch
from
5914b10
to
e99eb0e
Compare
ChrisSchinnerl
force-pushed
the
chris/rename-object-migration
branch
from
efc6dca
to
4609d22
Compare
ChrisSchinnerl
force-pushed
the
chris/rename-object-migration
branch
from
4609d22
to
aee2c43
Compare
peterjan
reviewed
May 17, 2024
peterjan
reviewed
May 17, 2024
ChrisSchinnerl
force-pushed
the
chris/rename-object-migration
branch
from
e58d3c6
to
b0275eb
Compare
peterjan
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first method migrated to the new raw sql database type. Starting with a smaller one to keep things easy.
NOTE:
DeleteObjectis different for SQLite and MySQL on purpose. SQLite is less granular when it comes to locking so in my experience performing the writing operation sooner rather than later in the txn reduces the frequency of locking errors.MySQL on the other hand seemed to benefit from reading the value first to avoid the optimistic locking MySQL performs in the common case.
I'm sure now that we keep these implementations separate we will find many more spots where reorganising queries within transactions will help us improve performance for individual database engines.