Migrate to new types fromcoreutils
#1233
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pj/single-address-store
Make use of new chain.Announcement and chain.ForEachHostAnnouncement helpers in coreutils
… pj/single-address-store
add SQL impl. for syncer.PeerStore
Make SQLStore implement SingleAddressStore
… pj/single-address-wallet
Upgrade coreutils dependency
This PR upgrades `coreutils` dependencies and adds a type for the `eventData`. This PR really only unblocks `its-happening` and allows me to merge in `dev`. After which I'll immediately change this to raw SQL and get rid of the awful `eventData` type (following this PR: #1272).
This PR is an intermediate step into cleanly getting `dev` merged into `its-happening`. This is currently a little awkward because we introduced `events` in `dev` which relies on consensus changes... Merging it into `its-happening` requires a little reshuffle because of that. I moved the subscriber to the `internal` package, and to avoid confusion I moved all (old) `internal/node` code into `host.go` because a) that will soon disappear anyway and b) we only need it to create test hosts. The idea is to give the subscriber the same events broadcaster as we do the bus, so the subscriber can notify us when consensus updates and the bus can notify us about everything else. I also moved the syncer in an attempt to clean up the bus constructor, not quite there yet though but figured I'd push this to avoid bloating the PR too much. --------- Co-authored-by: Chris Schinnerl <chris@sia.tech>
This PR merges in `dev` so `its-happening` is finally up-to-date and all PRs against it unblocked. There's really not that much to focus on except for the consensus update notification being broadcasted by the subscriber. I only do that if we're "synced". I'm considering to clean that up a bit though, now it's very much make-it-work. I do think the `subscriber` is the one that should be broadcasting that event. I think it's rather annoying though that the definition of "synced" is now a bit scattered. --------- Co-authored-by: Chris Schinnerl <chris@sia.tech>
This PR checks for the presence of a `consensus.db` file and if found will start the migration to the new `chain.db`. We merely log a warning the process could take hours, I think that's fine though if we properly communicate it when we release it.
This migrates chain code to raw SQL, this should help facilitate upgrading `coreutils` since some of the type changes are annoying to do with `gorm`. `NOTE`: this PR skips `TestBlocklist`, I'll fix that in a F/U since this PR blocks some other PRs --------- Co-authored-by: Chris Schinnerl <chris@sia.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
renterdto use the new types incoreutils, e.g. the wallet, syncer and chain manager.Keeping it as a
DRAFTfor the time being, now that we're play testing it on our nodes I figured it's a good time to look at the diff and keep it up-to-date withdevmore frequently.