storage,rhp: hide Read/Write system errors

host/storage/storage.go

@@ -913,7 +913,7 @@ func (vm *VolumeManager) Write(root types.Hash256, data *[rhp2.SectorSize]byte)
 				},
 				Timestamp: time.Now(),
 			})
-			return fmt.Errorf("failed to write sector data: %w", err)
+			return err
 		}
 		vm.log.Debug("wrote sector", zap.String("root", root.String()), zap.Int64("volume", loc.Volume), zap.Uint64("index", loc.Index), zap.Duration("elapsed", time.Since(start)))
 

host/storage/verrors_default.go

@@ -0,0 +1,13 @@
+//go:build !windows
+// +build !windows
+
+package storage
+
+import (
+	"errors"
+	"syscall"
+)
+
+func isNotEnoughStorageErr(err error) bool {
+	return errors.Is(err, syscall.ENOSPC)
+}

host/storage/verrors_windows.go

@@ -0,0 +1,14 @@
+//go:build windows
+// +build windows
+
+package storage
+
+import (
+	"errors"
+
+	"golang.org/x/sys/windows"
+)
+
+func isNotEnoughStorageErr(err error) bool {
+	return errors.Is(err, windows.ERROR_DISK_FULL)
+}

host/storage/volume.go

@@ -187,7 +187,11 @@ func (v *volume) WriteSector(data *[rhp2.SectorSize]byte, index uint64) error {
 	}
 	_, err := v.data.WriteAt(data[:], int64(index*rhp2.SectorSize))
 	if err != nil {
-		err = fmt.Errorf("failed to write sector to index %v: %w", index, err)
+		if isNotEnoughStorageErr(err) {
+			err = ErrNotEnoughStorage
+		} else {
+			err = fmt.Errorf("failed to write sector to index %v: %w", index, err)
+		}
 	}
 	go v.incrementWriteStats(err)
 	return err

rhp/v3/execute.go

@@ -104,8 +104,10 @@ func (pe *programExecutor) executeAppendSector(instr *rhp3.InstrAppendSector, lo
 	}
 
 	release, err := pe.storage.Write(root, sector)
-	if err != nil {
-		return nil, nil, fmt.Errorf("failed to write sector: %w", err)
+	if errors.Is(err, storage.ErrNotEnoughStorage) {
+		return nil, nil, err
+	} else if err != nil {
+		return nil, nil, ErrHostInternalError
 	}
 	pe.releaseFuncs = append(pe.releaseFuncs, release)
 	pe.updater.AppendSector(root)
@@ -275,7 +277,8 @@ func (pe *programExecutor) executeReadSector(instr *rhp3.InstrReadSector, log *z
 
 	sector, err := pe.storage.Read(root)
 	if err != nil {
-		return nil, nil, fmt.Errorf("failed to read sector %q: %w", root, err)
+		log.Error("failed to read sector", zap.String("root", root.String()), zap.Error(err))
+		return nil, nil, ErrHostInternalError
 	}
 
 	// if no proof was requested, return the data