RHPv4 Client #17
Draft
RHPv4 Client #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/rhpv4-client
branch
from
74ba279
to
09ab824
Compare
lukechampine
reviewed
Feb 7, 2024
rhp/v4/client.go
Outdated
| // dial a stream with a sane deadline | ||
| c.mu.Lock() | ||
| s := c.mux.DialStream() | ||
| c.mu.Unlock() |
There was a problem hiding this comment.
Because we swap out the mux sometimes
rhp/v4/client.go
Outdated
| } else if err := c.resetTransport(ctx); err != nil { | ||
| // failed to reset transport | ||
| c.mu.Unlock() | ||
| return fmt.Errorf("%v: %w", err, errRPC) |
There was a problem hiding this comment.
I expect the second error is unlikely to be helpful to the caller. I would just return errRPC here
There was a problem hiding this comment.
I think it's useful to know to determine whether we are not handling resetting the connection correctly or if resetting the connection actually fails. e.g. if the error is "connection refused" we might want to drop the mux completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8