Merge pull request #149 from SiaFoundation/ifelse

lint: Disable 'ifElseChain' gocritic check

.golangci.yml

@@ -65,6 +65,7 @@ linters-settings:
     # See https://go-critic.github.io/overview#checks-overview
     # To check which checks are enabled run `GL_DEBUG=gocritic golangci-lint run`
     # By default list of stable checks is used.
+    disable-all: true
     enabled-checks:
       - argOrder # Diagnostic options
       - badCond

types/policy.go

@@ -258,7 +258,7 @@ func (p SpendPolicy) String() string {
 			if i > 0 {
 				sb.WriteByte(',')
 			}
-			writeHex(pk.Key[:])
+			writeHex(pk.Key)
 		}
 		sb.WriteString("],")
 		sb.WriteString(strconv.FormatUint(uint64(p.SignaturesRequired), 10))

types/types.go

@@ -804,7 +804,7 @@ func (b *Block) ID() BlockID {
 // Implementations of fmt.Stringer, encoding.Text(Un)marshaler, and json.(Un)marshaler
 
 func stringerHex(prefix string, data []byte) string {
-	return prefix + ":" + hex.EncodeToString(data[:])
+	return prefix + ":" + hex.EncodeToString(data)
 }
 
 func marshalHex(prefix string, data []byte) ([]byte, error) {
@@ -897,7 +897,7 @@ func (s *Specifier) UnmarshalText(b []byte) error {
 
 // MarshalText implements encoding.TextMarshaler.
 func (uk UnlockKey) MarshalText() ([]byte, error) {
-	return marshalHex(uk.Algorithm.String(), uk.Key[:])
+	return marshalHex(uk.Algorithm.String(), uk.Key)
 }
 
 // UnmarshalText implements encoding.TextUnmarshaler.