Skip to content

Commit

Permalink
Centralize Ruby Version to .ruby-version
Browse files Browse the repository at this point in the history
Set minimum version of Rubocop to 1.61
This is to support `.ruby-version`: rubocop/rubocop#12645
Also commit the Gemfile.lock: https://bundler.io/guides/faq.html#:~:text=A%3A%20Yes%2C%20you%20should%20commit,towards%20new%20and%20existing%20contributors.
  • Loading branch information
george-ma authored and jenshenny committed Apr 23, 2024
1 parent 1254a5c commit 2057b2d
Show file tree
Hide file tree
Showing 8 changed files with 79 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/benchmark.yml
Expand Up @@ -13,7 +13,6 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.1
bundler-cache: true

- name: Run benchmark on branch
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
Expand Up @@ -13,7 +13,6 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler-cache: true

- name: Run Rubocop
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Expand Up @@ -2,7 +2,6 @@
doc
*.gem
.bundle
Gemfile.lock
pkg/*
vendor/
tmp/*
1 change: 0 additions & 1 deletion .rubocop.yml
Expand Up @@ -5,7 +5,6 @@ require:
- ./lib/statsd/instrument/rubocop.rb

AllCops:
TargetRubyVersion: 2.7
UseCache: true
SuggestExtensions: false
CacheRootDirectory: tmp/rubocop
Expand Down
1 change: 1 addition & 0 deletions .ruby-version
@@ -0,0 +1 @@
3.3.0
2 changes: 1 addition & 1 deletion Gemfile
Expand Up @@ -8,6 +8,6 @@ gem "minitest"
gem "rspec"
gem "mocha"
gem "yard"
gem "rubocop", ">= 1.0"
gem "rubocop", "~> 1.61"
gem "rubocop-shopify", require: false
gem "benchmark-ips"
75 changes: 75 additions & 0 deletions Gemfile.lock
@@ -0,0 +1,75 @@
PATH
remote: .
specs:
statsd-instrument (3.7.0)

GEM
remote: https://rubygems.org/
specs:
ast (2.4.2)
benchmark-ips (2.13.0)
diff-lcs (1.5.1)
json (2.7.1)
language_server-protocol (3.17.0.3)
minitest (5.22.3)
mocha (2.1.0)
ruby2_keywords (>= 0.0.5)
parallel (1.24.0)
parser (3.3.0.5)
ast (~> 2.4.1)
racc
racc (1.7.3)
rainbow (3.1.1)
rake (13.1.0)
regexp_parser (2.9.0)
rexml (3.2.6)
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
rspec-mocks (~> 3.13.0)
rspec-core (3.13.0)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-mocks (3.13.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
rubocop (1.62.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.31.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.2)
parser (>= 3.3.0.4)
rubocop-shopify (2.15.1)
rubocop (~> 1.51)
ruby-progressbar (1.13.0)
ruby2_keywords (0.0.5)
unicode-display_width (2.5.0)
yard (0.9.36)

PLATFORMS
arm64-darwin-23
ruby

DEPENDENCIES
benchmark-ips
minitest
mocha
rake
rspec
rubocop (~> 1.61)
rubocop-shopify
statsd-instrument!
yard

BUNDLED WITH
2.5.3
2 changes: 2 additions & 0 deletions statsd-instrument.gemspec
Expand Up @@ -20,5 +20,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]

spec.required_ruby_version = ">= 2.6.0"

spec.metadata['allowed_push_host'] = "https://rubygems.org"
end

0 comments on commit 2057b2d

Please sign in to comment.