Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dead code detection to Prism #527

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Migrate dead code detection to Prism #527

merged 11 commits into from
Mar 15, 2024

Commits on Mar 12, 2024

  1. Add dependency to Prism 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    81167d9 View commit details
    Browse the repository at this point in the history

  2. Update RBIs for gems 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b399fbc View commit details
    Browse the repository at this point in the history

  3. Migrate parsing to Prism 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a4d233a View commit details
    Browse the repository at this point in the history

  4. Remove dependency to SyntaxTree 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    614084b View commit details
    Browse the repository at this point in the history

  5. Regenerate gem RBIs 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    3d7e88f View commit details
    Browse the repository at this point in the history

  6. Introduce custom Prism visitor 

    A visitor that always go through `visit` to allow common behavior for all
nodes without having to define all the `visit_*` methods.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    19e10bd View commit details
    Browse the repository at this point in the history

  7. Migrate dead code indexing to Prism 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c857183 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Migrate dead code plugins to Prism 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0525a3e View commit details
    Browse the repository at this point in the history

  2. Migrate dead code remover to Prism 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    94c7ea4 View commit details
    Browse the repository at this point in the history

  3. Also require Tapioca when running Sorbet in test projects 

    By default, `srb` will look for RBIs coming from gems. Since we migrated to
Prism, Sorbet is now picking up the RBI shipped with the gem which results
in a lot of errors.

We can disable this behavior by using Tapioca. See sorbet/sorbet#3332.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0b32028 View commit details
    Browse the repository at this point in the history

  4. Use multiple lines to display parse exceptions 

    Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
    @Morriar
    Morriar committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    35b15d8 View commit details
    Browse the repository at this point in the history