New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all Sorbet related commands as subcommands #524
Conversation
option :sorbet_options, type: :string, default: "", desc: "Pass options to Sorbet" | ||
sig { params(directory: String).void } | ||
def bump(directory = ".") | ||
say_warning("This command is deprecated. Please use `spoom srb bump` instead.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People may wonder if the new one is the same or not. Would it be better to say it's been 'renamed' or 'moved'? Or we could append, "...instead, which has identical behavior".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think the release notes would be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but I suspect few people read them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(my comment is non-blocking)
Still keep an redirection from old commands for now but display a deprecation warning. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
4d889e3
to
246b0a9
Compare
Currently, all the commands are top level making both the code and DX a bit messy. I also want to make some space for other commands such as the
deadcode
related ones.Those are the commands currently merged:
With this change, all commands related to Sorbet are moved under the parent command
srb
:To avoid breaking right now, I kept the top level commands to redirect to the
srb
ones with a deprecation message:We can remove them in the later major version bump.