Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete some useless commands #520

Merged
merged 3 commits into from Mar 4, 2024
Merged

Delete some useless commands #520

merged 3 commits into from Mar 4, 2024

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Mar 1, 2024

The commands spoom config and spoom files are not useful, let's delete them.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added breaking-change Change breaking retro-compatibility chore Chore task labels Mar 1, 2024
@Morriar Morriar self-assigned this Mar 1, 2024
@Morriar Morriar requested a review from a team as a code owner March 1, 2024 18:56
@Morriar Morriar requested review from andyw8 and vinistock March 1, 2024 18:56
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@andyw8
Copy link
Contributor

andyw8 commented Mar 4, 2024

FYI the sfn-docs repo references the spoom config command.

@Morriar
Copy link
Collaborator Author

Morriar commented Mar 4, 2024

Thanks @andyw8 I didn't know about this docs and it points to an interesting feature: how to generate proper metrics for a componentized project 🤔

@Morriar Morriar merged commit 9b650e8 into main Mar 4, 2024
8 checks passed
@Morriar Morriar deleted the at-delete-commands branch March 4, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change breaking retro-compatibility chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants