Mark methods called by MiniTest.setup as alive #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcphillips
approved these changes
Sep 20, 2023
|
Interesting, is that part of the public API? I don't see it in the docs. |
andyw8
reviewed
Sep 21, 2023
|
|
||
| sig { override.params(indexer: Indexer, send: Send).void } | ||
| def on_send(indexer, send) | ||
| return unless send.recv.nil? && send.name == "setup" |
There was a problem hiding this comment.
Should we also consider teardown?
Morriar
force-pushed
the
at-fix-dead-setup
branch
from
799cfc5
to
1f4d3db
Compare
|
Indeed, it's a ActiveSupport::TestCase and not a Minitest one 🤦 I moved the rule to the right file and also handled |
|
Accidentally hit this branch. Please make sure to rebase this branch to the newest version before merging |
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-fix-dead-setup
branch
from
1f4d3db
to
a04f375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc. @kmcphillips