Fix Rubocop violations #1340
Closed
Fix Rubocop violations #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gemspec/DeprecatedAttributeAssignment Gemspec/OrderedDependencies
Layout/FirstHashElementLineBreak Layout/FirstMethodArgumentLineBreak Layout/LineContinuationLeadingSpace Layout/LineContinuationSpacing Layout/LineEndStringConcatenationIndentation Layout/MultilineArrayLineBreaks Layout/MultilineHashKeyLineBreaks Layout/MultilineOperationIndentation
Style/ConcatArrayLiterals Style/GlobalStdStream
…ingCopEnableDirective in RuboCop config
8 tasks
|
Thanks for the effort but I don't want these changes. shipit-engine predates the Shopify style guide and I don't want to make this much changes for a repo that is mostly stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1339, RuboCop was bumped to 1.61 to get these changes.
This PR addresses the new cops. I added
Style/OpenStructUse,Style/ClassMethodsDefinitionsandLint/MissingCopEnableDirectiveto the RuboCop exclusions.