Allow overrides for default task values via URL parameters #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muz
approved these changes
Dec 14, 2023
casperisfine
approved these changes
Dec 14, 2023
Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
Great suggestion, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow new task page to accept default value overrides for task variables. This should allow users to construct urls like
https://shipit.example.com/something/production/tasks/restart/new?REGION=gcp-us-east1and provide their parameters with a default value.One very important use-case here is links from documentation/playbooks, where we'd want to hardcode specific values for a task and allow the operator to review those and then click the button without having to re-type the values every time (especially dangerous when under fire).