Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give ConcurrentTaskRunning a clear error message #1313

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Give ConcurrentTaskRunning a clear error message #1313

merged 1 commit into from
Jul 14, 2023

Conversation

stephsachrajda
Copy link
Contributor

What

  • Updates ConcurrentTaskRunning error to have a clear error message

Why

  • The error name itself is clear, but "Conflict" is not, this way api users can pass along the message

@stephsachrajda stephsachrajda requested a review from a team July 14, 2023 19:00
@stephsachrajda stephsachrajda merged commit 764f2db into master Jul 14, 2023
16 checks passed
@stephsachrajda stephsachrajda deleted the give-concurrent-running-a-message branch July 14, 2023 19:27
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems July 14, 2023 19:35 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems October 5, 2023 21:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartiki975 kartiki975 kartiki975 approved these changes

@kwboyd-shopify kwboyd-shopify kwboyd-shopify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephsachrajda @kartiki975 @kwboyd-shopify