Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable line continuation cops #585

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Enable line continuation cops #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcece77
Enable line continuation cops
sambostock Oct 30, 2023
0d38859
Dump full RuboCop config
github-actions[bot] Oct 30, 2023
b985475
Add space before line continuation
sambostock Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rubocop-shopify.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Gem::Specification.new do |s|
s.name = "rubocop-shopify"
s.version = "2.14.0"
s.summary = "Shopify's style guide for Ruby."
s.description = "Gem containing the rubocop.yml config that corresponds to "\
s.description = "Gem containing the rubocop.yml config that corresponds to " \
"the implementation of the Shopify's style guide for Ruby."

s.license = "MIT"
Expand Down
4 changes: 2 additions & 2 deletions rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ Layout/HashAlignment:
EnforcedLastArgumentHashStyle: ignore_implicit

Layout/LineContinuationLeadingSpace:
Enabled: false
Enabled: true

Layout/LineContinuationSpacing:
Enabled: false
Enabled: true

Layout/LineEndStringConcatenationIndentation:
Enabled: true
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/full_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ Layout/LeadingEmptyLines:
Layout/LineContinuationLeadingSpace:
Description: Use trailing spaces instead of leading spaces in strings broken over
multiple lines (by a backslash).
Enabled: false
Enabled: true
VersionAdded: '1.31'
VersionChanged: '1.45'
EnforcedStyle: trailing
Expand All @@ -698,7 +698,7 @@ Layout/LineContinuationLeadingSpace:
- trailing
Layout/LineContinuationSpacing:
Description: Checks the spacing in front of backslash in line continuations.
Enabled: false
Enabled: true
VersionAdded: '1.31'
EnforcedStyle: space
SupportedStyles:
Expand Down