Request diagnostic refresh when RuboCop configs change #3041
+55
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Graphite App
andyw8
approved these changes
Jan 16, 2025
vinistock
force-pushed
the
01-10-request_diagnostic_refresh_when_rubocop_configs_change
branch
from
ec62865 to
5dfbc44
Compare
vinistock
force-pushed
the
01-10-request_diagnostic_refresh_when_rubocop_configs_change
branch
from
5dfbc44 to
89d3b59
Compare
Merge activity
|
vinistock
deleted the
01-10-request_diagnostic_refresh_when_rubocop_configs_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The explanation in microsoft/vscode-languageserver-node#1594 (comment) solved our issue clearing diagnostics. Push and pull diagnostics are two different collections, so you cannot clear diagnostics acquired via pull using a push with an empty array.
The correct solution is to request a diagnostic refresh to the editor, which will then trigger pull diagnostics for all open documents.
Implementation
Changed the implementation to clear our cache and then request a diagnostic refresh, which now correctly recomputes the diagnostics using the new RuboCop configs.
Automated Tests
Added a test to verify that we're request the refresh.
Manual Tests
Screen.Recording.2025-01-10.at.10.21.05.AM.mov