Add feature flag support to GlobalState #2826
Merged
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @vinistock and the rest of your teammates on |
vinistock
changed the title
vinistock
added
server
Graphite App
vinistock
force-pushed
the
11-04-add_the_ability_to_rollout_features_to_a_percetange_of_users
branch
from
718ef4d to
547631f
Compare
vinistock
force-pushed
the
11-04-start_passing_enabled_feature_flags_to_server
branch
from
c729b55 to
70540b6
Compare
KaanOzkan
approved these changes
Nov 5, 2024
vinistock
changed the base branch from
11-04-add_the_ability_to_rollout_features_to_a_percetange_of_users
to
graphite-base/2826
andyw8
reviewed
Nov 5, 2024
andyw8
approved these changes
Nov 5, 2024
andyw8
reviewed
Nov 5, 2024
vinistock
force-pushed
the
11-04-start_passing_enabled_feature_flags_to_server
branch
from
70540b6 to
b62cc31
Compare
vinistock
force-pushed
the
graphite-base/2826
branch
from
547631f to
7031842
Compare
Merge activity
|
vinistock
deleted the
11-04-start_passing_enabled_feature_flags_to_server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR starts passing the enabled feature flags to the server and storing it in the global state. That way the Ruby LSP and its add-ons can check for specific feature flags. This also allows users of other editors to opt into features through
initializationOptions.Implementation
Automated Tests
Added unit tests to verify feature flag processing and retrieval functionality.