Print Bundler progress to stderr when invoking CLI directly #2801
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
vinistock
force-pushed
the
vs-display-bundler-progress
branch
from
6172fb0 to
a8fa442
Compare
andyw8
approved these changes
Oct 29, 2024
vinistock
force-pushed
the
vs-display-bundler-progress
branch
from
a8fa442 to
d7ea37a
Compare
st0012
approved these changes
Oct 29, 2024
vinistock
force-pushed
the
vs-invoke-bundler-cli
branch
from
bbc0a44 to
0c4392b
Compare
vinistock
force-pushed
the
vs-display-bundler-progress
branch
from
d7ea37a to
e0bdfa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In launcher mode #2778, we don't see the Bundler output printed because we're setting the UI to silent. If we make the Thor shell used by Bundler print to stderr instead of stdout, then we can see the output normally.
Implementation
Started prepending a patch to the Thor shell to guarantee we can only print to stderr. This is only used in launch mode.
Automated Tests
Added a test.