Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept keyword splat options for server initialization #2744

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

vinistock
Copy link
Member

Motivation

Tiny change, but for our new launcher prototype we're going to need to pass more options when instantiating the server.

Implementation

This PR just makes the initialize method accept a splat of options.

@vinistock vinistock added server This pull request should be included in the server gem's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels Oct 21, 2024
@vinistock vinistock self-assigned this Oct 21, 2024
@vinistock vinistock requested a review from a team as a code owner October 21, 2024 18:49
@vinistock vinistock enabled auto-merge (squash) October 21, 2024 18:54
@vinistock vinistock merged commit ec3103d into main Oct 21, 2024
35 checks passed
@vinistock vinistock deleted the vs-accept-kw-splat-options branch October 21, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants