Remove aliased shapes #1254
Merged
Remove aliased shapes #1254
+28
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/remove_aliased_shapes
branch
from
cb8d321 to
73f9f5a
Compare
Morriar
reviewed
Dec 15, 2023
| @@ -80,7 +76,7 @@ def cache_get(request_name) | |||
| @cache[request_name] | |||
| end | |||
|
|
|||
| sig { params(edits: T::Array[EditShape], version: Integer).void } | |||
| sig { params(edits: T::Array[T::Hash[Symbol, T.untyped]], version: Integer).void } | |||
There was a problem hiding this comment.
I wonder if we could create a real Edit class instead?
There was a problem hiding this comment.
We receive these parameters from the language-server_protocol gem as hashes, so that would be a much more involved refactor. We'd need to start instantiating specialized objects for each type of request.
To be honest, I think it's a worth while contribution for the gem since passing hashes around is not very type friendly. But it'll take considerably more effort than this
There was a problem hiding this comment.
Yes, I've been meaning to do this refactor for the gem, actually. Maybe I can get this done this week.
andyw8
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Removed our type aliases with shapes as they present considerable performance overhead.