Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify RuboCop setup for RBI files #195

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Dec 19, 2023

This is based on how Tapioca itself is configured.

@andyw8 andyw8 requested a review from a team as a code owner December 19, 2023 15:28
@andyw8 andyw8 requested review from Morriar and st0012 December 19, 2023 15:28
@andyw8
Copy link
Contributor Author

andyw8 commented Dec 19, 2023

🤔 In ruby-lsp we actually have a different setup. We use a separate CI step bundle exec rubocop sorbet/rbi/shims so the Include setting in main .rubocop.yml is not necessary. I think the approach used by tapioca is preferable, since there is only one rubocop invocation needed.

@andyw8 andyw8 merged commit 5e5e119 into main Dec 19, 2023
11 checks passed
@andyw8 andyw8 deleted the andyw8/clarify-rubocop-rbi-setup branch December 19, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants