Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make incompatible override rule not fail on incomplete signatures #191

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Make incompatible override rule not fail on incomplete signatures #191

merged 1 commit into from
Oct 25, 2023

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Oct 25, 2023 •
edited

This cop is breaking while editing files in the Ruby LSP. If we have an incomplete signature, there won't be a block element.

@vinistock vinistock added the bugfix Fix a bug label Oct 25, 2023
@vinistock vinistock self-assigned this Oct 25, 2023
@vinistock vinistock requested a review from a team as a code owner October 25, 2023 15:56
@vinistock vinistock merged commit 8d87472 into main Oct 25, 2023
11 checks passed
@vinistock vinistock deleted the vs/fix_incompatible_override_breaking branch October 25, 2023 17:08
@shopify-shipit shopify-shipit bot temporarily deployed to production October 31, 2023 15:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@Morriar Morriar Awaiting requested review from Morriar Morriar is a code owner automatically assigned from Shopify/sorbet

@st0012 st0012 Awaiting requested review from st0012 st0012 is a code owner automatically assigned from Shopify/sorbet

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan

Assignees

@vinistock vinistock

Labels
bugfix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinistock @andyw8