Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable InternalAffairs/UndefinedConfig for now #184

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

sambostock
Copy link
Contributor

There appears to be a bug in the cop causing it to continue failing even if the missing config is added. Other Rubocop plugins (such as rubocop-rails and rubocop-performance) also disable it, citing

# FIXME: Workaround for a false positive caused by this cop when using `bundle exec rake`.

I didn't find any open issue in Rubocop, so I'll open one when I have the time to put together a simplified reproduction case.

Related to #183, which ran into this cop, and couldn't get it to pass.

There appears to be a bug in the cop causing it to continue failing even
if the missing config is added. Other Rubocop plugins (such as
`rubocop-rails` and `rubocop-performance`) also disable it, citing

> # FIXME: Workaround for a false positive caused by this cop when using `bundle exec rake`.
@sambostock sambostock merged commit a39b684 into main Oct 13, 2023
10 checks passed
@sambostock sambostock deleted the disable-undefined-config branch October 13, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants