Update RedundantExtendTSig to trim whole line

[bitwise-aiden]

Description

When running this cop it will leave whatever whitespace occurred at the start of the line, which means that if run in isolation may cause other violations.

This approach is in line with what occurs in ForbidExtendTSigHelpersInShims, replacing the whole line and removing any new line.

The thing to consider is that it will also remove any comment on the line, but this feels like a fine tradeoff since it would likely be to do with the extend in the first place and would need to be cleaned up.

[paracycle]

What if we did range_with_surrounding_space(range: node.source_range) instead?

[bitwise-aiden]

That's a lot cleaner. I'm guessing this will also take out additional newlines before and after?

[bitwise-aiden]

Ahh, that could be why

[bitwise-aiden]

Looking at the docs, I wonder how many cases would be solved with:

range_with_surrounding_space(range: node.source_range, side: :right) 

It feels like :both will take take too many lines, but I can see a case for extend T::Sig having trailing new lines. Absolutely not substantiated by anything but I think it would cover all these cases:

class SomeClass 
  extend T::Sig
end 

class SomeClass
end

class SomeClass 
  extendT::Sig

  def initialize; end
end

class SomeClass
  def initialize; end
end

class SomeClass
  include SomeHelperModule

  extend T::Sig

  def initialize; end
end

class SomeClass
  include SomeHelperModule

  def initialize; end
end

Writing those out has convinced me that it will likely yield the best results.

[bitwise-aiden]

Ahh, not quite! This one is wrong:

class SomeClass 
  extend T::Sig
end 

class SomeClass
  end

The indentation is kept because it doesn't go left. Though that becomes tough to manage since if it was anything other than end we would be fine with it.

Maybe it is best to keep it how it was and rely on the other cops to ensure the lines are cleaned up.

[paracycle]

Interesting, what if we did: range_with_surrounding_space(range: node.source_range, side: :right) and joined it with range_with_surrounding_space(range: node.source_range, side: :left, newlines: false). So:

add_range(
  range_with_surrounding_space(range: node.source_range, side: :left, newlines: false),
  range_with_surrounding_space(range: node.source_range, side: :right)
)

[bitwise-aiden]

That would then fail on:

class SomeClass
  extend T::Sig

  def initialize; end
end

class SomeClass
def initialize; end
end

It would be nice if there was a way to consume upto the next line that has content on it.

[paracycle]

ok, fair. I do agree that what we have is the best compromise. thanks for indulging my questions.

[bitwise-aiden]

Thanks for the inquiry, it's good to know what is going on at a deeper level.