Update Rubocop to 1.62.1

We need Rubocop to be bumped so that we have the [#12645](rubocop/rubocop#12645) patch of Rubocop 1.61.0. https://github.com/rubocop/rubocop/releases/tag/v1.61.0 Also run the rubocop autocorrects
Shopify · Mar 27, 2024 · 346464a · 346464a
1 parent b43acc9
commit 346464a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 13 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -10,16 +10,16 @@ GEM
     ast (2.4.2)
     byebug (11.1.3)
     diff-lcs (1.5.1)
-    json (2.6.3)
+    json (2.7.1)
     language_server-protocol (3.17.0.3)
-    parallel (1.23.0)
-    parser (3.2.2.3)
+    parallel (1.24.0)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
       racc
-    racc (1.7.1)
+    racc (1.7.3)
     rainbow (3.1.1)
     rake (13.1.0)
-    regexp_parser (2.8.1)
+    regexp_parser (2.9.0)
     rexml (3.2.6)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
@@ -34,23 +34,23 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.1)
-    rubocop (1.55.1)
+    rubocop (1.62.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.2.3)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.29.0)
-      parser (>= 3.2.1.0)
+    rubocop-ast (1.31.2)
+      parser (>= 3.3.0.4)
     rubocop-shopify (2.14.0)
       rubocop (~> 1.51)
     ruby-progressbar (1.13.0)
-    unicode-display_width (2.4.2)
+    unicode-display_width (2.5.0)
     yard (0.9.36)
 
 PLATFORMS

diff --git a/lib/rubocop/cop/sorbet/forbid_t_struct.rb b/lib/rubocop/cop/sorbet/forbid_t_struct.rb
@@ -79,7 +79,7 @@ def on_send(node)
             return unless t_struct_prop?(node)
 
             kind = node.method?(:const) ? :attr_reader : :attr_accessor
-            name = node.arguments[0].source.delete_prefix(":")
+            name = node.first_argument.source.delete_prefix(":")
             type = node.arguments[1].source
             default = nil
             factory = nil

diff --git a/lib/rubocop/cop/sorbet/sigils/valid_sigil.rb b/lib/rubocop/cop/sorbet/sigils/valid_sigil.rb
@@ -29,7 +29,8 @@ def investigate(processed_source)
           strictness = extract_strictness(sigil)
           return unless check_strictness_not_empty(sigil, strictness)
           return unless check_strictness_valid(sigil, strictness)
-          return unless check_strictness_level(sigil, strictness)
+
+          nil unless check_strictness_level(sigil, strictness)
         end
 
         def autocorrect(_node)