Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button, Link] Add touch action property #11845

Merged
merged 2 commits into from Apr 5, 2024
Merged

Conversation

kyledurand
Copy link
Contributor

@kyledurand kyledurand commented Apr 5, 2024

Micro optimization: removes the browser delay in waiting for a potential double tap.

https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action#manipulation

@kyledurand kyledurand added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Apr 5, 2024
@kyledurand kyledurand changed the title [Button] Add touch action property [Button, Link] Add touch action property Apr 5, 2024
@kyledurand kyledurand requested a review from ssetem April 5, 2024 15:00
@kyledurand kyledurand removed the 🤖Skip Changelog Causes CI to ignore changelog update check. label Apr 5, 2024
@kyledurand kyledurand merged commit 8145d73 into main Apr 5, 2024
16 of 17 checks passed
@kyledurand kyledurand deleted the button_add-touch-action branch April 5, 2024 17:02
aaronccasanova pushed a commit that referenced this pull request Apr 9, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.29.0

### Minor Changes

- [#11831](#11831)
[`99972a50b`](99972a5)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `text` custom properties in polaris-react v14.0.0

## @shopify/polaris@12.27.0

### Minor Changes

- [#11783](#11783)
[`0bf817afc`](0bf817a)
Thanks [@chloerice](https://github.com/chloerice)! - Added support to
`Filters` for indicating `appliedFilters` have unsaved changes

### Patch Changes

- [#11824](#11824)
[`79130eeea`](79130ee)
Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Lint
fixes


- [#11845](#11845)
[`8145d7326`](8145d73)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added
`touch-action: manipulation` to `Button` and `Link`

- Updated dependencies
\[[`79130eeea`](79130ee)]:
    -   @shopify/polaris-icons@8.11.1

## @shopify/polaris-icons@8.11.1

### Patch Changes

- [#11824](#11824)
[`79130eeea`](79130ee)
Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Added
missing `svgo` dev dependency

## polaris.shopify.com@0.67.4

### Patch Changes

- [#11851](#11851)
[`e2909baa9`](e2909ba)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
guidance.

- Updated dependencies
\[[`0bf817afc`](0bf817a),
[`79130eeea`](79130ee),
[`79130eeea`](79130ee),
[`8145d7326`](8145d73)]:
    -   @shopify/polaris@12.27.0
    -   @shopify/polaris-icons@8.11.1
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
Micro optimization: removes the browser delay in waiting for a potential
double tap.


https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action#manipulation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants