Add missing svgo dev dependency
#11824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilsonperkin
force-pushed
the
prettier-format
branch
from
48e3341
to
89d53c1
Compare
alex-page
approved these changes
Apr 2, 2024
aaronccasanova
approved these changes
Apr 2, 2024
sam-b-rose
approved these changes
Apr 4, 2024
jesstelford
force-pushed
the
prettier-format
branch
from
89d53c1
to
e18817c
Compare
|
I've attempted to track down the CI failure, but I'm get non-deterministic results from running the linter 🤔 Here are a sample of the errors I've gotten which seem to happen randomly when changing unrelated files. All were run in a fresh clone with a At this point, I honestly have no idea and given this doesn't appear to be failing in CI on other branches, I'm not going to bother digging deeper. |
|
I reverted a handful of the formatting updates, re-ran prettier on each file, and added the missing |
jesstelford
approved these changes
Apr 9, 2024
Merged
aaronccasanova
pushed a commit
that referenced
this pull request
Apr 9, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.29.0 ### Minor Changes - [#11831](#11831) [`99972a50b`](99972a5) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `text` custom properties in polaris-react v14.0.0 ## @shopify/polaris@12.27.0 ### Minor Changes - [#11783](#11783) [`0bf817afc`](0bf817a) Thanks [@chloerice](https://github.com/chloerice)! - Added support to `Filters` for indicating `appliedFilters` have unsaved changes ### Patch Changes - [#11824](#11824) [`79130eeea`](79130ee) Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Lint fixes - [#11845](#11845) [`8145d7326`](8145d73) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `touch-action: manipulation` to `Button` and `Link` - Updated dependencies \[[`79130eeea`](79130ee)]: - @shopify/polaris-icons@8.11.1 ## @shopify/polaris-icons@8.11.1 ### Patch Changes - [#11824](#11824) [`79130eeea`](79130ee) Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Added missing `svgo` dev dependency ## polaris.shopify.com@0.67.4 ### Patch Changes - [#11851](#11851) [`e2909baa9`](e2909ba) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action guidance. - Updated dependencies \[[`0bf817afc`](0bf817a), [`79130eeea`](79130ee), [`79130eeea`](79130ee), [`8145d7326`](8145d73)]: - @shopify/polaris@12.27.0 - @shopify/polaris-icons@8.11.1
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com> Co-authored-by: Jess Telford <jess.telford@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
While working on #11799 a number of lint warnings were reported which I've fixed, we'll look to ship these separately to avoid them bloating that PR.