New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the IndexTable
component to prevent a scrollbar flash
#11817
Conversation
…he table is rendered Co-authored-by: Marc Thomas <marc.thomas@shopify.com>
bce10a1
to
1ed8948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems safe enough 👍 We'd probably want to double check that hideScrollContainer
is getting set to false on mount where it needs to but that can happen when we 🎩 the version bump
/snapit |
🫰✨ Thanks @sam-b-rose! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240402181310" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@8.10.0 ### Minor Changes - [#11816](#11816) [`4b730c84d`](4b730c8) Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added some icons for image editing ### Patch Changes - [#11825](#11825) [`fd5b31d59`](fd5b31d) Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Add missing peer dependency on React ## @shopify/polaris@12.26.0 ### Minor Changes - [#11785](#11785) [`2a2f635ba`](2a2f635) Thanks [@mrcthms](https://github.com/mrcthms)! - Added the `defaultPaginatedSelectAllText` prop to `IndexTable` to support customizing the label of the checkbox in the header that selects all rows across pages when the table `hasMoreItems` ### Patch Changes - [#11833](#11833) [`810532c58`](810532c) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Revert responsive text style updates - [#11810](#11810) [`66dc0392a`](66dc039) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed Shift + click selection of `IndexTable.Row` not working in Firefox - [#11811](#11811) [`9aea67322`](9aea673) Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated `heading2xl` variant in `Text` component - [#11817](#11817) [`936765c92`](936765c) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - [IndexTable] Initially hide the scrollbar and update scrollbar padding - [#11819](#11819) [`35eb10c4f`](35eb10c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added multi select functionality to AlphaPicker - Updated dependencies \[[`fd5b31d59`](fd5b31d), [`4b730c84d`](4b730c8)]: - @shopify/polaris-icons@8.10.0 ## @shopify/polaris-migrator@0.28.6 ### Patch Changes - [#11813](#11813) [`c49809998`](c498099) Thanks [@lgriffee](https://github.com/lgriffee)! - Removed `Text` `heading2xl` and associated tokens from v14 font migration ## polaris.shopify.com@0.67.2 ### Patch Changes - [#11796](#11796) [`c8dc01330`](c8dc013) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action pattern guidance - [#11811](#11811) [`9aea67322`](9aea673) Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated `heading2xl` variant in `Text` component - Updated dependencies \[[`fd5b31d59`](fd5b31d), [`810532c58`](810532c), [`66dc0392a`](66dc039), [`9aea67322`](9aea673), [`4b730c84d`](4b730c8), [`2a2f635ba`](2a2f635), [`936765c92`](936765c), [`35eb10c4f`](35eb10c)]: - @shopify/polaris-icons@8.10.0 - @shopify/polaris@12.26.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…fy#11817) ### WHY are these changes introduced? The scrollbar in `IndexTable` initially shows and then hides on render. 🌀 [Spin link](https://admin.web.index-table-test.sam-rose.us.spin.dev/store/shop1) **Before** https://github.com/Shopify/polaris/assets/11774595/cc494771-cebb-4969-bed3-6d017ecf1c97 **After** No flash of scrollbar. ### WHAT is this pull request doing? This updates the default state of the scrollbar to be hidden and updates the `SCROLL_BAR_PADDING` since the inline padding has been increased from `--p-space-050` to `--p-space-200`). ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide Co-authored-by: Marc Thomas <marc.thomas@shopify.com>
WHY are these changes introduced?
The scrollbar in
IndexTable
initially shows and then hides on render.🌀 Spin link
Before
Screen.Recording.2024-04-02.at.9.54.25.AM.mov
After
No flash of scrollbar.
WHAT is this pull request doing?
This updates the default state of the scrollbar to be hidden and updates the
SCROLL_BAR_PADDING
since the inline padding has been increased from--p-space-050
to--p-space-200
).🎩 checklist
README.md
with documentation changes