[Checkbox] Fix shift click #11810
Merged
[Checkbox] Fix shift click #11810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @kyledurand! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-migrator@0.0.0-snapshot-20240401131855yarn add @shopify/polaris@0.0.0-snapshot-20240401131855yarn add @shopify/stylelint-polaris@0.0.0-snapshot-20240401131855 |
laurkim
approved these changes
Apr 1, 2024
|
/snapit |
|
🫰✨ Thanks @kyledurand! Your snapshots have been published to npm. Test the snapshots by updating your pnpm add --workspace-root @shopify/polaris-migrator@0.0.0-snapshot-20240401202037yarn add @shopify/polaris-migrator@0.0.0-snapshot-20240401202037npm install @shopify/polaris-migrator@0.0.0-snapshot-20240401202037pnpm add --workspace-root @shopify/polaris@0.0.0-snapshot-20240401202037yarn add @shopify/polaris@0.0.0-snapshot-20240401202037npm install @shopify/polaris@0.0.0-snapshot-20240401202037pnpm add --workspace-root @shopify/stylelint-polaris@0.0.0-snapshot-20240401202037yarn add @shopify/stylelint-polaris@0.0.0-snapshot-20240401202037npm install @shopify/stylelint-polaris@0.0.0-snapshot-20240401202037 |
chloerice
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Thanks for fixing this @kyledurand! Tested in Firefox and works well.
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
alex-page
approved these changes
Apr 2, 2024
Merged
sam-b-rose
pushed a commit
that referenced
this pull request
Apr 4, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@8.10.0 ### Minor Changes - [#11816](#11816) [`4b730c84d`](4b730c8) Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added some icons for image editing ### Patch Changes - [#11825](#11825) [`fd5b31d59`](fd5b31d) Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Add missing peer dependency on React ## @shopify/polaris@12.26.0 ### Minor Changes - [#11785](#11785) [`2a2f635ba`](2a2f635) Thanks [@mrcthms](https://github.com/mrcthms)! - Added the `defaultPaginatedSelectAllText` prop to `IndexTable` to support customizing the label of the checkbox in the header that selects all rows across pages when the table `hasMoreItems` ### Patch Changes - [#11833](#11833) [`810532c58`](810532c) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Revert responsive text style updates - [#11810](#11810) [`66dc0392a`](66dc039) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed Shift + click selection of `IndexTable.Row` not working in Firefox - [#11811](#11811) [`9aea67322`](9aea673) Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated `heading2xl` variant in `Text` component - [#11817](#11817) [`936765c92`](936765c) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - [IndexTable] Initially hide the scrollbar and update scrollbar padding - [#11819](#11819) [`35eb10c4f`](35eb10c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added multi select functionality to AlphaPicker - Updated dependencies \[[`fd5b31d59`](fd5b31d), [`4b730c84d`](4b730c8)]: - @shopify/polaris-icons@8.10.0 ## @shopify/polaris-migrator@0.28.6 ### Patch Changes - [#11813](#11813) [`c49809998`](c498099) Thanks [@lgriffee](https://github.com/lgriffee)! - Removed `Text` `heading2xl` and associated tokens from v14 font migration ## polaris.shopify.com@0.67.2 ### Patch Changes - [#11796](#11796) [`c8dc01330`](c8dc013) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action pattern guidance - [#11811](#11811) [`9aea67322`](9aea673) Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated `heading2xl` variant in `Text` component - Updated dependencies \[[`fd5b31d59`](fd5b31d), [`810532c58`](810532c), [`66dc0392a`](66dc039), [`9aea67322`](9aea673), [`4b730c84d`](4b730c8), [`2a2f635ba`](2a2f635), [`936765c92`](936765c), [`35eb10c4f`](35eb10c)]: - @shopify/polaris-icons@8.10.0 - @shopify/polaris@12.26.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#11809 https://bugzilla.mozilla.org/show_bug.cgi?id=559506#:~:text=18%20days%20ago-,If%20you%20shift%2Bclick%20or%20ctrl%2Bclick%20on%20a%20label,checkbox%2C%20checkbox%20is%20not%20checked. ### WHAT is this pull request doing? This PR changes our checkbox input from being 1px / 1px hidden, to full size with opactiy 0. So the click event gets triggered. ### How to 🎩 [Spin](https://admin.web.checkbox.kyle-durand.us.spin.dev/store/shop1/orders) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #11809
https://bugzilla.mozilla.org/show_bug.cgi?id=559506#:~:text=18%20days%20ago-,If%20you%20shift%2Bclick%20or%20ctrl%2Bclick%20on%20a%20label,checkbox%2C%20checkbox%20is%20not%20checked.
WHAT is this pull request doing?
This PR changes our checkbox input from being 1px / 1px hidden, to full size with opactiy 0. So the click event gets triggered.
How to 🎩
Spin
🎩 checklist
README.mdwith documentation changes