Optimize Money#split(n) for large n
#287
Merged
+273
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
split-allocations
branch
from
7165649
to
d676473
Compare
elfassy
reviewed
Apr 5, 2024
elfassy
reviewed
Apr 5, 2024
casperisfine
force-pushed
the
split-allocations
branch
from
d676473
to
128c2d4
Compare
elfassy
reviewed
Apr 10, 2024
elfassy
reviewed
Apr 10, 2024
elfassy
reviewed
Apr 10, 2024
When passing a very large number to split, it result in allocating between 2 and 3 arrays of such size. e..g `Money.new(1_000_000).split(1_000_000)` allocates an array of size 1M, then concat it with an empty array, which cause Ruby to allocate another array of 1M entries. All this cause two `8MB` mallocs, which doesn't sound like that much but if done a few times is likely to trigger Ruby GC. Instead we can return a small enumerable that will simply act like an array, but won't actually materialize it.
casperisfine
force-pushed
the
split-allocations
branch
from
128c2d4
to
52f9b82
Compare
elfassy
approved these changes
Apr 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a very large number to split, it result in allocating between 2 and 3 arrays of such size. e..g
Money.new(1_000_000).split(1_000_000)allocates an array of size 1M, then concat it with an empty array, which cause Ruby to allocate another array of 1M entries.All this cause two
8MBmallocs, which doesn't sound like that much but if done a few times is likely to trigger Ruby GC.Instead we can return a small enumerable that will simply act like an array, but won't actually materialize it.