Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage of the to_liquid_value feature. #1674

Merged
merged 2 commits into from Jan 16, 2023
Merged

Improve test coverage of the to_liquid_value feature. #1674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdb5cb0
Remove == method from drops from testing to_liquid_value
dylanahsmith Jan 13, 2023
619ed3f
Add some additional to_liquid_value assertions
dylanahsmith Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/integration/variable_test.rb
View file
Open in desktop
Expand Up @@ -24,13 +24,17 @@ def test_variable_lookup_calls_to_liquid_value

def test_if_tag_calls_to_liquid_value
assert_template_result('one', '{% if foo == 1 %}one{% endif %}', { 'foo' => IntegerDrop.new('1') })
assert_template_result('one', '{% if foo == eqv %}one{% endif %}', { 'foo' => IntegerDrop.new(1), 'eqv' => IntegerDrop.new(1) })
assert_template_result('one', '{% if 0 < foo %}one{% endif %}', { 'foo' => IntegerDrop.new('1') })
assert_template_result('one', '{% if foo > 0 %}one{% endif %}', { 'foo' => IntegerDrop.new('1') })
assert_template_result('one', '{% if b > a %}one{% endif %}', { 'b' => IntegerDrop.new(1), 'a' => IntegerDrop.new(0) })
assert_template_result('true', '{% if foo == true %}true{% endif %}', { 'foo' => BooleanDrop.new(true) })
assert_template_result('true', '{% if foo %}true{% endif %}', { 'foo' => BooleanDrop.new(true) })

assert_template_result('', '{% if foo %}true{% endif %}', { 'foo' => BooleanDrop.new(false) })
assert_template_result('', '{% if foo == true %}True{% endif %}', { 'foo' => BooleanDrop.new(false) })

assert_template_result('one', '{% if a contains x %}one{% endif %}', { 'a' => [1], 'x' => IntegerDrop.new(1) })
end

def test_unless_tag_calls_to_liquid_value
Expand Down
8 changes: 0 additions & 8 deletions test/test_helper.rb
View file
Open in desktop
Expand Up @@ -131,10 +131,6 @@ def initialize(value)
@value = value.to_i
end

def ==(other)
@value == other
end

def to_s
@value.to_s
end
Expand All @@ -150,10 +146,6 @@ def initialize(value)
@value = value
end

def ==(other)
@value == other
end

def to_liquid_value
@value
end
Expand Down