Initialize context to nil on the Drop class #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We believe this will reduce megamorphic exits in YJIT. There are currently 241 separate shapes generated with edge_name "@context" in SFR. Initializing it to nil will significantly reduce this number.
casperisfine
approved these changes
Jan 12, 2023
|
cc @Shopify/liquid @Shopify/liquid-perf this is a super small change to play better with Ruby 3.2 and YJIT. I'm taking the liberty to merge this. |
@jemmaissroff What's SFR? |
|
It is a reference to Shopify's Storefront Renderer application, which was blogged about here: https://shopify.engineering/how-shopify-reduced-storefront-response-times-rewrite Thanks for the reminder for us to avoid these internal acronyms in our open source repos. |
|
:D On the flipside, it's a ton of fun getting the occasional glimpse into the dynamics y'all are working with. Thanks for being willing to share. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We believe this will reduce megamorphic exits in YJIT. There are currently 241 separate shapes generated with edge_name "@context" in SFR. Initializing it to nil will significantly reduce this number.