Use cache built into ruby/setup-ruby action
#1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dylanahsmith |
.github/workflows/liquid.yml
Outdated
| @@ -1,39 +1,36 @@ | |||
| name: Liquid | |||
| on: [push, pull_request] | |||
|
|
|||
| env: | |||
| BUNDLE_PATH: "vendor/bundle" | |||
There was a problem hiding this comment.
Can this environment variable be removed? Since https://github.com/ruby/setup-ruby#bundle-config says
To perform caching, this action will use bundle config --local path $PWD/vendor/bundle.
Therefore, the Bundler path should not be changed in your workflow for the cache to work (no bundle config path).
There was a problem hiding this comment.
Sure. I'll remove it.
Although, it being set to vendor/bundle doesn't affect the caching. (Can be observed via the log report for Ruby 2.7 against the second commit).
dylanahsmith
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ruby/setup-rubyGitHub Action has a provision for caching installed bundle. Using that cache is better than handling it locally.