Have subclasses of a tag inherit superclass's disabled tags (#1646)

Shopify · Oct 27, 2022 · 3e8994c · 3e8994c
1 parent 7ccac29
commit 3e8994c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/lib/liquid/tag.rb b/lib/liquid/tag.rb
@@ -14,12 +14,18 @@ def parse(tag_name, markup, tokenizer, parse_context)
       end
 
       def disable_tags(*tag_names)
-        @disabled_tags ||= []
-        @disabled_tags.concat(tag_names)
+        tag_names += disabled_tags
+        define_singleton_method(:disabled_tags) { tag_names }
         prepend(Disabler)
       end
 
       private :new
+
+      protected
+
+      def disabled_tags
+        []
+      end
     end
 
     def initialize(tag_name, markup, parse_context)

diff --git a/lib/liquid/tag/disabler.rb b/lib/liquid/tag/disabler.rb
@@ -3,14 +3,6 @@
 module Liquid
   class Tag
     module Disabler
-      module ClassMethods
-        attr_reader :disabled_tags
-      end
-
-      def self.prepended(base)
-        base.extend(ClassMethods)
-      end
-
       def render_to_output_buffer(context, output)
         context.with_disabled_tags(self.class.disabled_tags) do
           super