Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敿 Update dependency to require node v18 #1543

Merged
merged 1 commit into from
Dec 5, 2023
Merged

馃敿 Update dependency to require node v18 #1543

merged 1 commit into from
Dec 5, 2023

Conversation

michenly
Copy link
Contributor

@michenly michenly commented Dec 4, 2023 •
edited

WHY are these changes introduced?

This project's node dependency is out of date:

  1. Remix v2 require v18 which had been part of Hydrogen since Oct 2023
  2. we use fetch without polyfill, however, fetch is not part of node global till v18
  3. Node v16 & v17 end of life had already been reached

WHAT is this pull request doing?

Update minimal node dependency to v18

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@michenly michenly marked this pull request as ready for review December 4, 2023 22:41
@michenly michenly self-assigned this Dec 4, 2023
@michenly michenly force-pushed the mc-update-node-18 branch 2 times, most recently from 82998a8 to 9fb3990 Compare December 5, 2023 15:41
@michenly michenly merged commit 848c626 into main Dec 5, 2023
9 checks passed
@michenly michenly deleted the mc-update-node-18 branch December 5, 2023 17:39
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Dec 5, 2023
Merged
juanpprieto pushed a commit that referenced this pull request Dec 7, 2023
@michenly @juanpprieto
馃敿 Update dependency to require node v18 (#1543)
fb4a3bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

@blittle blittle Awaiting requested review from blittle

Assignees

@michenly michenly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michenly @frandiox