Remove deprecated props #1435
Remove deprecated props #1435
Conversation
| }); | ||
|
|
||
| defaultHeaders[STOREFRONT_REQUEST_GROUP_ID_HEADER] = | ||
| storefrontHeaders?.requestGroupId || requestGroupId || generateUUID(); | ||
| storefrontHeaders?.requestGroupId || generateUUID(); |
There was a problem hiding this comment.
Unrelated but curious: does the SFAPI require this request-group-id ? Or could it be undefined?
Just asking because generating a UUID in this place can be confusing. It should come from the request itself, otherwise we risk to have different UUID generated in different places -- like, this has taken me some time to debug when working on /debug-network and found out MiniOxygen wasn't adding ids properly.
If it is required then it makes sense to keep it I guess.
There was a problem hiding this comment.
I also think it didn't make sense to be here. requestGroupId is not mandatory for a storefront api call.
The goal of the request group id is to identify the sub requests belonging to a main request.
In Oxygen, we are guarantee to get it from getStorefrontHeaders from remix-oxygen.
In development, I think we can rely on mini-oxygen or worker to generate that for us. They weren't doing that before so it got generated at this line.
WHY are these changes introduced?
Remove deprecated props:
createStorefrontClient'sbuyerIpandrequestGroupId<Image>component'sloaderOptionsandwidthsWHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist