Hydrogen React - Add Language to CartProvider #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
|
Hi @Qubica, thanks for this great PR! Considering that this is not a breaking change (languageCode defaults to EN), we feel this should be a Could you please update the changeset to |
blittle
force-pushed
the
feature/cart-provider-i18n
branch
from
99fc08d
to
da5d7f1
Compare
blittle
reviewed
Oct 16, 2023
blittle
reviewed
Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
CartProvider doesn't take translations into account
Fixes #1403
WHAT is this pull request doing?
Adds language to the graphql queries. E.g. This will fetch the product titles in the correct language.