Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Codegen dependencies and make it stable #1108

Merged
merged 30 commits into from
Oct 26, 2023
Merged

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jul 17, 2023

This tries to update codegen dependencies and make it stable.

It is blocked by some bug introduced upstream. The error thrown when generating the demo-store types is: Cannot read properties of null (reading 'union'), from this line.
It seems it can't infer selection nodes when using fragment spreads (around here).
Fixed in dotansimha/graphql-code-generator#9709 . We are also patching this bug until this is merged and released.

@frandiox
Copy link
Contributor Author

Note: example of problematic fragment that worked on @graphql-codegen/cli@3 but doesn't work in >4 (error :Cannot read properties of null (reading 'union')):

 lines(first: $numCartLines) {
      nodes {
        ...CartLine
      }
   }

@github-actions github-actions bot had a problem deploying to preview October 17, 2023 09:33 Failure
@frandiox frandiox changed the base branch from 2023-04 to main October 17, 2023 09:33
@frandiox frandiox marked this pull request as ready for review October 17, 2023 09:34
@frandiox frandiox changed the title [WIP] Update codegen dependencies Update Codegen dependencies and make it stable Oct 17, 2023
@frandiox frandiox requested a review from a team October 17, 2023 16:11
@frandiox
Copy link
Contributor Author

Ready to review! 🙌

@wizardlyhel wizardlyhel mentioned this pull request Oct 20, 2023
12 tasks
@frandiox frandiox merged commit ad45656 into main Oct 26, 2023
9 checks passed
@frandiox frandiox deleted the fd-codegen-stable branch October 26, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants