[3.59] Fix shopify theme dev and shopify theme console proxies following session changes and bring back the legacy shopify theme push implementation in CI/CD workflows
#3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1653 tests passing in 765 suites. Report generated by 🧪jest coverage report action from 3deb6a4 |
karreiro
force-pushed
the
theme-patch-proxy
branch
from
cdbc456
to
d5fa4b2
Compare
karreiro
changed the title
shopify theme dev and shopify theme console proxiesshopify theme dev and shopify theme console proxies following session changes and bring back the legacy shopify theme push implementation in CI/CD workflows
…llowing session changes and bring the legacy `shopify theme push` implementation in CI/CD workflows
karreiro
force-pushed
the
theme-patch-proxy
branch
from
d5fa4b2
to
3deb6a4
Compare
mgmanzella
approved these changes
Apr 22, 2024
This was referenced Apr 23, 2024
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes regressions in the hot-reload mechanism on
shopify theme devandshopify theme consoledue to platform changes at session. Additionally, it brings the legacyshopify theme pushimplementation back in CI workflows.WHAT is this pull request doing?
shopify theme devandshopify theme consoleproxies, this PR changes the session cookie from_secure_session_idfrom_shopify_essential.shopifyignore/--ignore/--only, this PR adopts the legacy implementation in CI/CDs workflows (bringing the implementation back to the same state it was on3.58.2)How to test your changes?
Proxy
CI/CD workflows
Post-release steps
None.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.