Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support to the blocks/ directory in the shopify theme push command #3676

Merged
merged 2 commits into from Apr 12, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Apr 9, 2024

WHY are these changes introduced?

Introduce support to the blocks/ directory in the shopify theme push command

WHAT is this pull request doing?

This PR updates the theme filesystem module to support the blocks/ directory locally.

How to test your changes?

  • Create a theme with files in the blocks/ directory
  • Run shopify-dev theme push -u -t test
  • Notice they get uploaded

Post-release steps

None.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@karreiro karreiro requested a review from jamesmengo April 9, 2024 07:49
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.14% 6829/9466
🟡 Branches 69.21% 3342/4829
🟡 Functions 70.96% 1823/2569
🟡 Lines 73.29% 6439/8786

Test suite run success

1627 tests passing in 755 suites.

Report generated by 🧪jest coverage report action from f258449

Copy link
Contributor

@jamesmengo jamesmengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Tested with push and pull with flex_sections beta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants