Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme] Update theme push theme selection text #3670

Merged
merged 1 commit into from Apr 8, 2024

Conversation

jamesmengo
Copy link
Contributor

WHY are these changes introduced?

  • Updates text to be more accurate for the push command

How to test your changes?

pnpm shopify theme push --path <PATH_TO_THEME>
image

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@jamesmengo jamesmengo self-assigned this Apr 5, 2024
@jamesmengo jamesmengo added Type: Enhancement New feature or request Area: @shopify/theme @shopify/theme package issues labels Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@jamesmengo jamesmengo requested a review from a team April 5, 2024 18:39
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72% (-0.13% 🔻)
6751/9376
🟡 Branches
69.19% (+0.01% 🔼)
3296/4764
🟡 Functions
70.74% (-0.22% 🔻)
1799/2543
🟡 Lines
73.15% (-0.13% 🔻)
6366/8703
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app.ts
84.4% (-0.55% 🔻)
70.69% (-1.44% 🔻)
86.84%
86.02% (-0.44% 🔻)
🟢
... / loader.ts
93.13% (+0.14% 🔼)
86.81% (-0.02% 🔻)
95.12% (+0.39% 🔼)
94.1% (+0.35% 🔼)
🟡
... / select-app.ts
65.38% (-2.47% 🔻)
50% (-16.67% 🔻)
87.5%
68.18% (-1.38% 🔻)
🟡
... / monorail.ts
69.23% (-4.1% 🔻)
40% (-10% 🔻)
100%
69.23% (-4.1% 🔻)

Test suite run success

1617 tests passing in 754 suites.

Report generated by 🧪jest coverage report action from 2e7431a

@jamesmengo jamesmengo disabled auto-merge April 5, 2024 18:44
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jamesmengo! I believe we just need to add a patch changelog, and then we will be ready to ship :)

@jamesmengo jamesmengo added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 741398c Apr 8, 2024
29 checks passed
@jamesmengo jamesmengo deleted the jmeng/reword_push_selection branch April 8, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants