Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated header regex #3658

Merged
merged 1 commit into from Apr 4, 2024
Merged

Updated header regex #3658

merged 1 commit into from Apr 4, 2024

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Apr 4, 2024

Thanks to @ZedNaught for the original PR!

WHY are these changes introduced?

Fixes #3462

WHAT is this pull request doing?

Tweak the regex to support shpca_... ; adds some new tests

Copy link
Contributor

github-actions bot commented Apr 4, 2024

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.14% 6824/9460
🟡 Branches 69.17% 3338/4826
🟡 Functions 70.98% 1822/2567
🟡 Lines 73.28% 6434/8780

Test suite run success

1625 tests passing in 755 suites.

Report generated by 🧪jest coverage report action from 6a0c6b9

@shauns shauns added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 2998aec Apr 4, 2024
30 checks passed
@shauns shauns deleted the auth-token-regex-shpca branch April 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with token regex for header builder
3 participants