Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): sets focus to the search input after selection #3430

Conversation

jongsue
Copy link
Contributor

@jongsue jongsue commented Feb 12, 2019

Addresses #3349.

focus-after-selection

@codecov-io
Copy link

codecov-io commented Feb 12, 2019

Codecov Report

Merging #3430 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3430   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         172      172           
  Lines        2819     2819           
=======================================
  Hits         2817     2817           
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1623e5c...655ea92. Read the comment docs.

@layershifter
Copy link
Member

I need to merge #3428 before.
Tried the similar fix today, but there were issues with broken key handlers.

@layershifter
Copy link
Member

layershifter commented Feb 17, 2019

I added some small changes. Actually, this PR don't fix #3349 because the focus will be still lost on usual <Dropdown selection />. Going to merge this PR because it fixes the issue for <Dropdown search selection />.

@layershifter layershifter merged commit b8f5002 into Semantic-Org:master Feb 17, 2019
@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants