docs(Portal): fix controlled Portal usage

[Fabianopb]

As discussed in #3408 the usage of Portal as a controlled component was wrong in the docs creating a false positive bug. The proper way puts the control inside the Portal's trigger:

(Closes #3408)

[codecov-io]

Codecov Report

Merging #3420 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3420   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         172      172           
  Lines        2838     2838           
=======================================
  Hits         2836     2836           
  Misses          2        2

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8a7eb...da50215. Read the comment docs.

[layershifter]

Actually, the issue comes from EventStack that incorrectly works with browser frames (click on button should not be fired actually).

There is an experiment with new approach: https://codesandbox.io/s/9yw3vq6774 I need to spend more time on it to test other scenarios and perform cleanup.

I will update the example later today.

[Fabianopb]

So would that mean that the fix should be done in EventStack in the end?

[layershifter]

So would that mean that the fix should be done in EventStack in the end?

@Fabianopb Actually, yes. But, I'm not ready to ship a correct fix for right now. I need to resolve the issue correctly and forever 👍

[layershifter]

@Fabianopb I've updated an example, now it works more correctly. Please let me know if it is fine 🚶

[Fabianopb]

Now the external button is solely used to open the Portal, which can be closed via the internal button or by clicking outside. Sounds fair too!

[levithomason]

Released in semantic-ui-react@0.86.0.