Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(eventStack): fix issues with event subscriptions #3189

Merged
merged 4 commits into from
Oct 3, 2018

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Oct 2, 2018

Fixes: #3006.
Details: layershifter/event-stack#4

BREAKING CHANGES

This PR fixes existing issues with multiple Modals, Popups and Dropdown's. However, it changes the behaviour of the Sidebar component that was introduced in v0.81.2. This update is strongly recommend if you're using 0.81.0 or higher.

You also can control the behaviour of Sidebar with the target prop, #3191.

Manual checks

Sorry, something went wrong.

Oleksandr Fediashov added 3 commits October 2, 2018 16:33
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #3189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3189   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2790     2790           
=======================================
  Hits         2788     2788           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a779351...965f857. Read the comment docs.

@layershifter layershifter changed the title breaking(eventStack): fix issues with event subscriptions WIP | BREAKING(eventStack): fix issues with event subscriptions Oct 2, 2018
@layershifter layershifter changed the title WIP | BREAKING(eventStack): fix issues with event subscriptions BREAKING(eventStack): fix issues with event subscriptions Oct 3, 2018
@layershifter layershifter merged commit 73f52b1 into master Oct 3, 2018
@layershifter layershifter deleted the fix/eventstack-sub branch October 3, 2018 11:18
@levithomason
Copy link
Member

However, it changes the behaviour of the Sidebar component that was introduced in v0.81.2.

Can we get a before / after update in the description? Thanks!

@levithomason
Copy link
Member

Released in semantic-ui-react@0.83.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup: when multiple popups present, click on the other trigger doesn't close original popup
3 participants