Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popup): missing CSS style update #3109

Merged
merged 3 commits into from
Sep 10, 2018

Conversation

pferreir
Copy link
Contributor

This PR should fix #3050. I suspect this was introduced by 06ab95f, with the removal of requestAnimationFrame(...).

Verified

This commit was signed with the committer’s verified signature.
edolstra Eelco Dolstra
@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #3109 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3109      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         163      163              
  Lines        2739     2742       +3     
==========================================
+ Hits         2737     2740       +3     
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae2781...7597681. Read the comment docs.

@levithomason
Copy link
Member

Superb! Thanks for the excellent PR.

@levithomason levithomason merged commit 01ef927 into Semantic-Org:master Sep 10, 2018
@levithomason
Copy link
Member

Released in semantic-ui-react@0.82.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup no longer updates when horizontalOffset changes
4 participants