-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified delete cookie added code and test #15386
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@aguspe requesting Review. |
Great work Pallavi, approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an extra test that validates what happens when the value is nil
it 'throws an error when cookie name is an empty string' do
expect { driver.manage.delete_cookie(nil) }
.to raise_error(ArgumentError, /Cookie name cannot be null or empty/)
end
thanks @aguspe , understood. added the code snippet. Kindly review when you can and let me know. grateful for your continued help. |
Thank you @p0deje . |
Contribution to #15044 |
thanks @nvborisenko , i forgot the original PR number. |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Fixed delete Cookie and added code and test
Motivation and Context
it is required.
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
Added validation to
delete_cookie
to prevent null or empty names.Updated integration tests to cover invalid cookie name scenarios.
Ensured existing tests for cookie deletion remain functional.
Changes walkthrough 📝
bridge.rb
Add validation for `delete_cookie` method
rb/lib/selenium/webdriver/remote/bridge.rb
ArgumentError
for invalid cookie names.manager_spec.rb
Add and update tests for cookie deletion
rb/spec/integration/selenium/webdriver/manager_spec.rb
ArgumentError
is raised for invalid cookie names.